Fixes mealie when meal plan is empty #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's nothing in the meal plan for the current day, the /api/groups/mealplans/today endpoint will simply return an `[]` response. This case wasn't guarded for in the template before this fix.
7 tasks
It's already checked on line 9. Co-authored-by: Bastien Wirtz <[email protected]>
|
@bastienwirtz I've moved the texts to be computed properties as well now. 👍 |
bastienwirtz
approved these changes
Nov 4, 2024
|
Thank you @rhardih ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's nothing in the meal plan for the current day, the /api/groups/mealplans/today endpoint will simply return an
[]response.This case wasn't guarded for in the template before this fix.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Follow up to #721.
Type of change
Checklist:
config.ymlfile