Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for BAT to 2, (keep existing compat) #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2022

This pull request changes the compat entry for the BAT package from 3 to 3, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@oschulz oschulz force-pushed the compathelper/new_version/2022-05-07-01-21-48-406-00555467615 branch from f0d091c to e05efd1 Compare May 7, 2022 01:21
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a2efa51). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   79.58%           
=======================================
  Files           ?        3           
  Lines           ?      240           
  Branches        ?        0           
=======================================
  Hits            ?      191           
  Misses          ?       49           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2efa51...e05efd1. Read the comment docs.

@oschulz
Copy link
Member

oschulz commented May 7, 2022

Leaving this open to keep CompatHelper quiet, but PartitionedParallelSampling won't support BAT v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants