fix review comments

bazaarvoice · Nov 6, 2024 · a40a48c · a40a48c
1 parent da60cdb
commit a40a48c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/queue/src/main/java/com/bazaarvoice/emodb/queue/QueueModule.java b/queue/src/main/java/com/bazaarvoice/emodb/queue/QueueModule.java
@@ -85,13 +85,6 @@ protected void configure() {
         bind(new TypeLiteral<Supplier<Boolean>>() {}).annotatedWith(DedupEnabled.class).toInstance(Suppliers.ofInstance(true));
         install(new EventStoreModule("bv.emodb.queue", _metricRegistry));
 
-        // Bind Kafka services
-        bind (KafkaAdminService.class).asEagerSingleton();
-        bind(KafkaProducerService.class).asEagerSingleton();
-
-        // Bind Step Function Service
-        bind(StepFunctionService.class).asEagerSingleton();
-
 
         // Bind the Queue instance that the rest of the application will consume
         bind(QueueService.class).to(DefaultQueueService.class).asEagerSingleton();

diff --git a/queue/src/main/java/com/bazaarvoice/emodb/queue/core/AbstractQueueService.java b/queue/src/main/java/com/bazaarvoice/emodb/queue/core/AbstractQueueService.java
@@ -458,7 +458,7 @@ private void startStepFunctionExecution(Map<String, String> parameters, String q
             String timestamp = String.valueOf(System.currentTimeMillis());
             queueName = stepFunctionService.sanitizeExecutionName(queueName);
             // Check if queueType is "dedupq" and prepend "D" to execution name if true
-            String executionName = (queueType.equalsIgnoreCase("dedupq") ? "D_" : "") + queueName + "_" + timestamp;;
+            String executionName = (queueType.equalsIgnoreCase("dedupq") ? "D_" : "") + queueName + "_" + timestamp;
             // Start the Step Function execution
             stepFunctionService.startExecution(stateMachineArn, inputPayload, executionName);
 

diff --git a/sor/src/main/java/com/bazaarvoice/emodb/sor/core/DefaultDataStore.java b/sor/src/main/java/com/bazaarvoice/emodb/sor/core/DefaultDataStore.java
@@ -757,7 +757,6 @@ public void beforeWrite(Collection<RecordUpdate> updateBatch) {
                     }
                 }
                 if (!updateRefs.isEmpty()) {
-                    _eventWriterRegistry.getDatabusWriter().writeEvents(updateRefs);
                     if(getDataThrottlerValue())
                         _kafkaProducerService.sendMessages(MASTER_FANOUT_TOPIC, updateRefs, "update");
                     else