PD-220325-Add-logs-for-the-megabus-for-debugging-purpose #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharadwaj-k
reviewed
Oct 9, 2023
megabus/src/main/java/com/bazaarvoice/megabus/refproducer/MegabusRefProducer.java
Show resolved
Hide resolved
megabus/src/main/java/com/bazaarvoice/megabus/refproducer/MegabusRefProducer.java
Outdated
Show resolved
Hide resolved
megabus/src/main/java/com/bazaarvoice/megabus/refproducer/MegabusRefProducer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
What Are We Doing Here?
Added few logs in megabus which will helps us to debug the provisioning issue where keys are not reflecting.
These are very specific to the api keys table.
How to Test and Verify
Check out this PR
2.Build the local, pls refer screenshot below.
Profit
Risk
If added will be useful in debugging.
Level
Low
Required Testing
No testing required as for this, already run the local build.
Risk Summary
None
Code Review Checklist
Tests are included. If not, make sure you leave us a line or two for the reason.
Pulled down the PR and performed verification of at least being able to
build and run.
Well documented, including updates to any necessary markdown files. When
we inevitably come back to this code it will only take hours to figure out, not
days.
Consistent/Clear/Thoughtful? We are better with this code. We also aren't
a victim of rampaging consistency, and should be using this course of action.
We don't have coding standards out yet for this project, so please make sure to address any feedback regarding STYLE so the codebase remains consistent.
PR has a valid summary, and a good description.