Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-233234: Kodak_Jersey_upgrade_Exceptions #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhijeet-BazaarVoice
Copy link
Contributor

Github Issue

https://bazaarvoice.atlassian.net/browse/PD-233234

What Are We Doing Here?

Increasing the timeout of the blob client for jersey2

How to Test and Verify

  1. Check out this PR
  2. Run Command X, Click Button Y
  3. Profit

Risk

Level

medium

Required Testing

None

Risk Summary

This changes needed as part of kodak request where they are reporting about timeout exception.

Code Review Checklist

  • Pulled down the PR and performed verification of at least being able to
    build and run.

  • Well documented, including updates to any necessary markdown files. When
    we inevitably come back to this code it will only take hours to figure out, not
    days.

  • Consistent/Clear/Thoughtful? We are better with this code. We also aren't
    a victim of rampaging consistency, and should be using this course of action.
    We don't have coding standards out yet for this project, so please make sure to address any feedback regarding STYLE so the codebase remains consistent.

  • PR has a valid summary, and a good description.

Copy link

@bharadwaj-k bharadwaj-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Evaluate in prod and revert if it does not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants