fix: doc pages (take 2!) #1327
Merged
fix: doc pages (take 2!) #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke the patch when changing the URLs because the change was done in a context line that doesn't exist in the real branch.
Update to docs patches so that they all build with the stardoc from main. NOTE: I used this gist to generate and test these patches: https://gist.github.com/jjmaestro/8f42d1ea04988ca86011de427b245ceb
jjmaestro
force-pushed
the
fix-doc-pages-2
branch
from
c6cd173 to
40e0f59
Compare
* Add pre-commit linting and validation * Auto-generate the strategy matrix * Move Bazelisk and mdBook versions to `env` so that it's easier to test and upgrade to new versions. * `fail-fast: false` so that when one of the matrix jobs fails so that we can see failures for all of the jobs (easier to debug and the jobs are lightweight so it's not too costly). * Simplify the patching of old branches * Make steps easier to read, shortening lines and adding whitespace
jjmaestro
force-pushed
the
fix-doc-pages-2
branch
from
40e0f59 to
70a44bc
Compare
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes the doc page generation! :) I've tested it in my
mainbranch so that the workflows would run and produce this: https://jjmaestro.github.io/rules_foreign_cc/ :) Once this PR lands, CI/CD should finally be back to always green!This PR does:
docs-0.3.0.patch)stardocversion inmainpagesGH Actions workflow:envso that it's easier to test and upgrade to new versions.fail-fast: falseso that when one of the matrix jobs fails so that we can see failures for all of the jobs (easier to debug and the jobs are lightweight so it's not too costly).