Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make multiple modules contributing to the same maven repo namespace warning less verbose and duplicated #1295

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Make multiple modules contributing to the same maven repo namespace warning less verbose and duplicated #1295

merged 2 commits into from
Dec 12, 2024

Conversation

jin
Copy link
Collaborator

@jin jin commented Dec 11, 2024 •
edited
Loading

Fix feedback about noisy logs from bazelbuild/bazel-worker-api#7 (comment)

What was previously:

(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'
(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'
(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'
(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'
(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'
(15:01:37) DEBUG: /private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'protobuf' and now in 'bazel_worker_java'

should now be:

(15:01:37) DEBUG: The maven repository 'maven' has contributions from multiple bzlmod modules, and will be resolved together: ["protobuf", "bazel_worker_java"]

@jin jin marked this pull request as ready for review December 11, 2024 10:59
@jin jin requested review from shs96c and cheister as code owners December 11, 2024 10:59
@jin jin enabled auto-merge (squash) December 11, 2024 11:00
@jin jin mentioned this pull request Dec 11, 2024
Open
shs96c
shs96c approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shs96c
shs96c approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

private/extensions/maven.bzl Outdated Show resolved Hide resolved
@jin jin disabled auto-merge December 12, 2024 05:07
@jin jin merged commit b7afb76 into bazel-contrib:master Dec 12, 2024
6 of 7 checks passed
ahumesky pushed a commit to ahumesky/rules_jvm_external that referenced this pull request Dec 12, 2024
@jin @ahumesky
Make multiple modules contributing to the same maven repo namespace w…
db421ee 
…arning less verbose and duplicated (bazel-contrib#1295)

* Make multiple modules contributing to the same maven repo namespace warning less verbose and duplicated

* Update maven.bzl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

@cheister cheister Awaiting requested review from cheister cheister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jin @shs96c