Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1656

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 20, 2024

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (io_opentracing_cpp, opentracing-cpp) have been updated in this PR. Please review the changes.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 21, 2024

@fmeum , @meteorcloudy ,
This follows this discussion

/skip-url-stability-check

@meteorcloudy meteorcloudy added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Mar 21, 2024
meteorcloudy
meteorcloudy previously approved these changes Mar 21, 2024
@bazel-io bazel-io dismissed meteorcloudy’s stale review March 21, 2024 10:21

Require module maintainers' approval for newly pushed changes.

modules/opentracing-cpp/1.6.0/presubmit.yml Outdated Show resolved Hide resolved
modules/opentracing-cpp/1.6.0/presubmit.yml Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 marked this pull request as draft March 21, 2024 20:50
@mmorel-35 mmorel-35 force-pushed the opentracing-cpp/v1.6.0 branch 4 times, most recently from bbb0305 to a6cbc01 Compare March 21, 2024 22:44
@mmorel-35 mmorel-35 marked this pull request as ready for review March 21, 2024 22:47
@meteorcloudy meteorcloudy merged commit 1d96bcc into bazelbuild:main Mar 22, 2024
16 checks passed
@mmorel-35 mmorel-35 deleted the opentracing-cpp/v1.6.0 branch March 22, 2024 10:12
Wyverald pushed a commit to bazelbuild/continuous-integration that referenced this pull request Apr 22, 2024
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants