Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of upb #1660

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Add new version of upb #1660

merged 8 commits into from
Mar 22, 2024

Conversation

keith
Copy link
Member

@keith keith commented Mar 21, 2024

This mostly copies from the previous version, which is missing some
macOS fix commits. The only change from the previous version in the bcr
is adding a new patch with an alias for the textformat target which is
used by grpc.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (upb) have been updated in this PR. Please review the changes.

@keith keith added the skip-url-stability-check Skip the URL stability check for the PR label Mar 21, 2024
@keith keith force-pushed the ks/add-new-version-of-upb branch from 1a60329 to fab87fa Compare March 21, 2024 18:01
This mostly copies from the previous version, which is missing some
macOS fix commits. The only change from the previous version in the bcr
is adding a new patch with an alias for the textformat target which is
used by grpc.
@keith keith force-pushed the ks/add-new-version-of-upb branch from fab87fa to 772d907 Compare March 21, 2024 18:03
@keith
Copy link
Member Author

keith commented Mar 21, 2024

I used the version number scheme from the previous versions but I used today's date, maybe I should use the date of the last commit instead?

@keith keith enabled auto-merge (squash) March 21, 2024 18:33
@keith keith requested a review from comius March 21, 2024 18:33
@meteorcloudy
Copy link
Member

maybe I should use the date of the last commit instead?

Yes, that's what we did for previous versions.

As of August 25, 2023, μpb has moved into the protobuf repo here. All further development is happening there, and this repo is no longer being updated.

I guess this will be the last upb version anyway?

@keith
Copy link
Member Author

keith commented Mar 22, 2024

updated to the commit date version number

@keith keith merged commit 65cfe57 into main Mar 22, 2024
18 checks passed
@Wyverald Wyverald deleted the ks/add-new-version-of-upb branch March 22, 2024 18:30
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
This mostly copies from the previous version, which is missing some
macOS fix commits. The only change from the previous version in the bcr
is adding a new patch with an alias for the textformat target which is
used by grpc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants