Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1777

Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Apr 6, 2024

Hello @alexeagle, @gregmagolan, @jbedard, modules you maintain (aspect_rules_js) have been updated in this PR. Please review the changes.

@hunshcn
Copy link

hunshcn commented Apr 9, 2024

ping @alexeagle @gregmagolan

@alexeagle alexeagle added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 9, 2024
alexeagle
alexeagle previously approved these changes Apr 9, 2024
@alexeagle alexeagle enabled auto-merge (squash) April 9, 2024 15:23
bazel-io
bazel-io previously approved these changes Apr 9, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

drop windows again
@bazel-io bazel-io dismissed stale reviews from alexeagle and themself April 12, 2024 22:48

Require module maintainers' approval for newly pushed changes.

@alexeagle alexeagle merged commit c29d48b into bazelbuild:main Apr 12, 2024
14 checks passed
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants