Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #1820

Closed
wants to merge 1 commit into from
Closed

[email protected] #1820

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (google-cloud-cpp) have been updated in this PR. Please review the changes.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Apr 13, 2024
@mmorel-35 mmorel-35 marked this pull request as draft April 13, 2024 12:37
@mmorel-35
Copy link
Contributor Author

There is at least two problems here :

ERROR: file:///Users/buildkite/builds/bk-macstudio-10/bazel/bcr-presubmit/modules/rules_jvm_external/6.0/MODULE.bazel:65:13: name 'use_repo_rule' is not defined
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> [email protected] -> [email protected] -> [email protected] -> [email protected]: error executing MODULE.bazel file for [email protected]

googleapis seems incompatible with bazel 6

The other is

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel: no such target '@@googleapis~//:googleapis_system_includes': target 'googleapis_system_includes' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/google-cloud-cpp~/google/cloud/BUILD.bazel:176:11: no such target '@@googleapis~//:googleapis_system_includes': target 'googleapis_system_includes' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel and referenced by '@@google-cloud-cpp~//google/cloud:google_cloud_cpp_grpc_utils_private'

googleapis version doesn't have the googleapis_system_includes target

@keith , would you be able to provide some assistance on those as you provided googleapis module in the BCR ?

@keith
Copy link
Member

keith commented Apr 13, 2024

Anything that depends on the newest rules_jvm_external transitively requires bazel 7. I didn't investigate how reasonable it would be to workaround.

On the missing target issue is it because of a version expectation mismatch? Or is that one more recent than the BCR upload?

@mmorel-35
Copy link
Contributor Author

2.16.0 is not the most recent version of google cloud cpp so it’s probably better to try with the most recent I guess but as grpc is using this one I tried to aligned with it

@keith
Copy link
Member

keith commented May 6, 2024

i would toss the bazel 6.x from CI here, then it looks like the errors on 7.x are real

keith
keith reviewed May 6, 2024
View reviewed changes
modules/google-cloud-cpp/2.16.0/patches/googleapis.patch Outdated
+ patches = [],
+ )
+
+non_module_deps = module_extension(implementation = non_module_deps_impl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did merge a version of googleapis into the BCR, can we use that version or do we need a different one for this? i noticed ODR violations if we have 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed It and now it seems like some expected target from googleapis are missing or have been changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it missing the googleapis_system_includes target? seems like that's a bespoke thing for this repo https://github.com/googleapis/google-cloud-cpp/blob/f28d70b78f291e3c2074b25dd16c22fbed79cb97/bazel/googleapis.BUILD#L25C13-L25C39

Maybe we can patch that in somehow instead?

Copy link
Contributor Author

@mmorel-35 mmorel-35 May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. Any idea on how to proceed ?

@bazel-io
Copy link
Member

bazel-io commented May 7, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (google-cloud-cpp) have been updated in this PR. Please review the changes.

@mmorel-35 mmorel-35 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith left review comments

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @bazel-io @keith @fmeum