Add [email protected] which fixes [email protected]. #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The differences are: * Removed `strip_prefix` from source.json, the top level directory in the zip must be retained. * Separated public and private headers into `hdrs` and `srcs` respectively.
|
Hello @Vertexwahn, @phaedon, modules you maintain (glm) have been updated in this PR. Please review the changes. |
Vertexwahn
previously approved these changes
Apr 20, 2024
bazel-io
previously approved these changes
Apr 20, 2024
|
@jruoff If you like you can add yourself to the maintainer section |
bazel-io
dismissed stale reviews from Vertexwahn and themself
Require module maintainers' approval for newly pushed changes.
fmeum
approved these changes
Apr 20, 2024
aiuto
pushed a commit
to aiuto/bazel-central-registry
that referenced
this pull request
Jun 3, 2024
Before this change, running `bazel query "labels(hdrs, @glm)"` resulted in `INFO: Empty results`. With this change the module correctly exports the public headers of glm. The differences are: * Removed `strip_prefix` from `source.json`, the top level directory in the zip must be retained. This fixes the main issue, the module is unusable without this. * Separated public and private headers into `hdrs` and `srcs` respectively. IIUC `textual_hdrs` is meant for public headers as well, whereas the `*.inl` files (and files in the `detail/` sub directory) of glm are not meant to be included directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, running
bazel query "labels(hdrs, @glm)"resulted inINFO: Empty results. With this change the module correctly exports the public headers of glm.The differences are:
strip_prefixfromsource.json, the top level directory in the zip must be retained. This fixes the main issue, the module is unusable without this.hdrsandsrcsrespectively. IIUCtextual_hdrsis meant for public headers as well, whereas the*.inlfiles (and files in thedetail/sub directory) of glm are not meant to be included directly.