Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1866

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (com_github_benchsci_rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

@meteorcloudy
Copy link
Member

@ewianda @ColinHeathman

Can you please rebase this PR to HEAD to get fixes from #1866?

Also, is it intentional to call this module com_github_benchsci_rules_nodejs_gazelle instead of rules_nodejs_gazelle? FYI @alexeagle

@ewianda
Copy link
Contributor

ewianda commented Apr 24, 2024

@ewianda @ColinHeathman

Can you please rebase this PR to HEAD to get fixes from #1866?

Also, is it intentional to call this module com_github_benchsci_rules_nodejs_gazelle instead of rules_nodejs_gazelle? FYI @alexeagle

@meteorcloudy what will be the process of renaming the module

@meteorcloudy
Copy link
Member

what will be the process of renaming the module

Just change it in your MODULE.bazel file and the entry name used in this PR.

@bazel-io
Copy link
Member

Hello @alexeagle, modules you maintain (aspect_rules_lint) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @dzbarsky, modules you maintain (aws-in-a-box) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @aherrmann, modules you maintain (rules_zig) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @morambro, modules you maintain (tink_cc) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @zadlg, modules you maintain (tree-sitter-c-bazel) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bzip2, rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

@ewianda
Copy link
Contributor

ewianda commented Apr 25, 2024

hi @meteorcloudy I am stuck with trying to rename the module Can you advice on how to fix this

@meteorcloudy
Copy link
Member

meteorcloudy commented Apr 25, 2024

@ewianda
Copy link
Contributor

ewianda commented Apr 26, 2024

@meteorcloudy we have decided to keep the original module name

@meteorcloudy
Copy link
Member

Can you please check the windows failure?

@ewianda
Copy link
Contributor

ewianda commented Apr 30, 2024

@meteorcloudy can you please take a look

@ewianda
Copy link
Contributor

ewianda commented May 6, 2024

@alexeagle @meteorcloudy can I please get this reviewed

@alexeagle alexeagle added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label May 6, 2024
@alexeagle alexeagle merged commit 92a7131 into bazelbuild:main May 6, 2024
14 checks passed
@alexeagle
Copy link
Contributor

Sorry for the delays! Notifications in this repo has gotten a bit out of hand with all the C++ projects being added.

aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
zaucy pushed a commit to zaucy/bazel-central-registry that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants