Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #2055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #2055

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (hedron_compile_commands) have been updated in this PR. Please review the changes.

@mmorel-35
Copy link
Contributor Author

Please add usual labels.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 18, 2024
@mmorel-35
Copy link
Contributor Author

Ready to be reviewed

@mmorel-35 mmorel-35 mentioned this pull request May 18, 2024
Merged
mmorel-35
mmorel-35 commented May 18, 2024
View reviewed changes
modules/hedron_compile_commands/metadata.json
Comment on lines +5 to +6
"email": "[email protected]",
"name": "No Maintainer Specified"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpsauer, would you like to defined as maintainer ?
Anyone else to add ?
Do you have a public email to declare here ?

Suggested change
"email": "[email protected]",
"name": "No Maintainer Specified"
"github": "cpsauer",
"name": "Chris Sauer"

@cpsauer
Copy link

cpsauer commented May 18, 2024

Hey @mmorel-35, let's discuss first over in your original PR in the tool itself to centralize discussion in one place and spare these guy's inboxes. In brief, this tool is designed to be used as a dev dependency (dev_dependency = True), as in the readme, and I think that would likely resolve what I'm guessing is your underlying issue here. Let's discuss more over there!

@fmeum, in the meantime, if you'd be down to hold off on merging, that'd be much appreciated.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented May 18, 2024 •
edited
Loading

A dedicated and complete issue has been published here
hedronvision/bazel-compile-commands-extractor#189

@cpsauer
Copy link

cpsauer commented May 18, 2024

Oh shoot. Sorry. Hadn't seen just yet.

@cpsauer
Copy link

cpsauer commented May 18, 2024 •
edited
Loading

Let's switch discussion over to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @bazel-io @cpsauer @fmeum