-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curl 8.8.0 #2233
Add curl 8.8.0 #2233
Conversation
Hello @keith, modules you maintain (curl) have been updated in this PR. Please review the changes. |
FYI: With Bazel 7.2.0 we have no support for overlays - could instead of patches offer directly |
looks like that isn't quite ready yet :/ #2240 |
7e1ef65
to
e4d0f9a
Compare
+ flag_values = {":http_only": "true"}, | ||
+) | ||
+ | ||
+# Curl's default CA path depends on the OS. If CURL_CA_BUNDLE/CURL_CA_PATH are not set, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should provide some defaults here. i started on this here https://github.com/bazelbuild/bazel-central-registry/pull/1943/files#diff-400335528b8cf846395d95f2877a3ff732563a63b7b0ef2be7bac192532e78acR627 actually not even allowing overrides. I think overrides are probably fine but this kinda locks us into a API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something similar was my first approach, in 16dfd0d.
I think it would be OK to start small and build this out iteratively.
It would also be great to allow the user to bring-your-own hermetic cabundle although admittedly I haven't actually tried that yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the defaults i linked are probably fine to start with so it "just works" in the common case on the explicitly supported OS's
Based on #2233 but provides platform specific defaults
submitted #2381 w/ the platform defaults |
Based on #2233 but provides platform specific defaults
https://github.com/curl/curl/releases/tag/curl-8_8_0