Restore minimal Python support in Protobuf v25+ #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR. Please review the changes. |
|
@zhangskz This is backporting the patches you reviewed. |
|
@fmeum could you please trigger the tests? |
|
Could you use this link for the archive instead: https://github.com/protocolbuffers/protobuf/releases/download/v26.0/protobuf-26.0.tar.gz |
fmeum
added
the
presubmit-auto-run
zhangskz
approved these changes
Jun 13, 2024
bazel-io
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Protobuf v25 Python support with Bzlmod broke with the introduction of
system_python. This is a regression compared to previous versions.This re-adds minimal Python support and adds a target to the presubmit check in order to avoid backsliding in the future.
This backports the following patches: