Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wheelos_common_msgs #2341

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

daohu527
Copy link
Contributor

@daohu527 daohu527 commented Jul 1, 2024

Added the common_msg library, which mainly uses protobuf to define the message format of the autonomous driving system.

@bazel-io
Copy link
Member

bazel-io commented Jul 1, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (common_msgs) have been updated in this PR. Please review the changes.

@daohu527 daohu527 force-pushed the common_msgs branch 3 times, most recently from 1901942 to efef2d1 Compare July 1, 2024 03:06
fmeum
fmeum previously approved these changes Jul 1, 2024
@fmeum fmeum enabled auto-merge (squash) July 1, 2024 09:06
@Wyverald
Copy link
Member

Wyverald commented Jul 1, 2024

would you consider renaming this module to wheelos_common_msgs? common_msgs is a very generic name and I'd think most people wouldn't expect it to be specifically related to autonomous driving systems.

@daohu527
Copy link
Contributor Author

daohu527 commented Jul 2, 2024

Ok, that's a good idea, I'll change the name

auto-merge was automatically disabled July 2, 2024 01:21

Head branch was pushed to by a user without write access

@bazel-io
Copy link
Member

bazel-io commented Jul 2, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (wheelos_common_msgs) have been updated in this PR. Please review the changes.

@bazel-io bazel-io dismissed fmeum’s stale review July 2, 2024 01:21

Require module maintainers' approval for newly pushed changes.

@meteorcloudy meteorcloudy changed the title add common_msg add wheelos_common_msgs Jul 3, 2024
@daohu527 daohu527 force-pushed the common_msgs branch 2 times, most recently from 92d292b to 729bd1c Compare July 3, 2024 16:04
wheelos_common_msgs defines the messages for autonomous driving
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 633105d into bazelbuild:main Jul 3, 2024
16 checks passed
@daohu527 daohu527 deleted the common_msgs branch July 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants