Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2359

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Jul 3, 2024

Hello @jsharpe, modules you maintain (rules_foreign_cc) have been updated in this PR. Please review the changes.

jsharpe
jsharpe previously approved these changes Jul 4, 2024
bazel-io
bazel-io previously approved these changes Jul 4, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@bazel-io bazel-io dismissed stale reviews from jsharpe and themself July 4, 2024 13:08

Require module maintainers' approval for newly pushed changes.

jsharpe
jsharpe previously approved these changes Jul 4, 2024
bazel-io
bazel-io previously approved these changes Jul 4, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

jsharpe
jsharpe previously approved these changes Jul 4, 2024
@bazel-io bazel-io dismissed stale reviews from jsharpe, jsharpe, and themself July 4, 2024 14:14

Require module maintainers' approval for newly pushed changes.

jsharpe
jsharpe previously approved these changes Jul 4, 2024
bazel-io
bazel-io previously approved these changes Jul 4, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@bazel-io bazel-io dismissed stale reviews from jsharpe and themself July 4, 2024 14:34

Require module maintainers' approval for newly pushed changes.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy enabled auto-merge (squash) July 4, 2024 14:52
@meteorcloudy meteorcloudy merged commit 6d400ff into bazelbuild:main Jul 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants