[email protected]

[publish-to-bcr-bot]

Release: https://github.com/bazelbuild/rules_python/releases/tag/0.34.0

Automated by Publish to BCR

[bazel-io]

Hello @rickeylev, @f0rmiga, modules you maintain (rules_python) have been updated in this PR. Please review the changes.

[aignas]

Looks like building the wheel for abseil is broken in the example, but that has to do with the something that cmanged in the CI. Could we skip this check and merge as it is?

[Wyverald]

We probably can just force submit this, but looping in @fweikert @meteorcloudy to confirm -- do we need to upgrade the C++ toolchain on the macOS VMs or something?

[meteorcloudy]

This is not caused by our recent Mac VM migration, those jobs ran on old Mac fleet.

Probably abseil version got upgraded in the new version? Then you'll need

bazel-central-registry/modules/abseil-cpp/20240116.2/presubmit.yml

Line 17 in 7f6becd

- '--cxxopt=-std=c++14'

[rickeylev]

rules_python doesn't depend on abseil, though, not directly anyways. Maybe this is coming from something with the proto rules? The failure seems to point to //py_proto_library:message_test as the failure. I'm guessing its trying to compile protoc and failing.

Maybe from this: WARNING: For repository 'rules_proto', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph

[rickeylev]

add --cxxopt=-std=c++14 to build flags

Well, I guess I could add that to our bcr presubmit config, if that fixes it. I don't really like having a different config for BCR vs the actual project, though; it makes last-mile release issues like this more common.

I'm a bit confused, though.

• We don't have that set in the rules_python CI config, and things work OK there.
• If we have to add it to this bcr config, doesn't that mean all downstream users of (presumably) rules_proto also have to add it?

The second point seems particularly invasive. Am I missing something?

[rickeylev]

I created #2397 to test out the presubmit.yml changes. Even with the --cxxopt=-std=c++14 added, it still gives the same error: https://buildkite.com/bazel/bcr-presubmit/builds/6616#019099bc-9d89-4381-831e-b8a948231e50

[rickeylev]

Ok, it looks if both --host_cxxopt and --cxxopt are set to the c++14 value, then BCR's CI is happy.

This still feels like an issue on...idk, the bcr or rules_proto side? But we can just add those to our bcr presubmit config in the meantime.

[rickeylev]

I've approved. Can we force-merge this PR? The presubmits from #2397 confirm that the issue is with the presubmit config, and the rules_python code is otherwise fine.

[bazel-io]

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

[meteorcloudy]

@rickeylev Thanks for looking into this!