Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "websocketpp" on Mac OS X. #2370

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix "websocketpp" on Mac OS X. #2370

merged 2 commits into from
Jul 11, 2024

Conversation

BYVoid
Copy link
Contributor

@BYVoid BYVoid commented Jul 5, 2024

This change fixes the build on Mac OS X. According to the original CMakeLists.txt, "rt" is not linked on Mac OS X.

    if (NOT APPLE)
        set (WEBSOCKETPP_PLATFORM_LIBS pthread rt)
    else()
        set (WEBSOCKETPP_PLATFORM_LIBS pthread)
    endif()

@bazel-io
Copy link
Member

bazel-io commented Jul 5, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (websocketpp) have been updated in this PR. Please review the changes.

Copy link

google-cla bot commented Jul 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Wyverald
Copy link
Member

Wyverald commented Jul 8, 2024

Existing versions cannot be changed on BCR. Please create a new version with a .bcr.<N> suffix (so 0.8.2.bcr.1 here).

@BYVoid
Copy link
Contributor Author

BYVoid commented Jul 10, 2024

Created 0.8.2.bcr.1 instead.

@meteorcloudy meteorcloudy added the skip-url-stability-check Skip the URL stability check for the PR label Jul 11, 2024
@meteorcloudy
Copy link
Member

@meteorcloudy
Copy link
Member

meteorcloudy commented Jul 11, 2024

@carbo-asr And can you please sign the Google CLA.

…on the operating system.

This change fixes the build on Mac OS X. According to the original CMakeLists.txt, "rt" is not linked on Mac OS X.

        if (NOT APPLE)
            set (WEBSOCKETPP_PLATFORM_LIBS pthread rt)
        else()
            set (WEBSOCKETPP_PLATFORM_LIBS pthread)
        endif()
@BYVoid
Copy link
Contributor Author

BYVoid commented Jul 11, 2024

"All contributors are covered under a CLA with Google".

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 11, 2024
@meteorcloudy
Copy link
Member

Please fix

BcrValidationResult.FAILED: The patch file `modules/websocketpp/0.8.2.bcr.1/patches/add_build_file.patch` has expected integrity value `sha256-KhVOfO47POB3xqoHdeOs+dYbn0dp0aAQddYt8ZWZqcI=`, but the real integrity value is `sha256-95DACIWxqhjix5VgVssEYee5pjCnf/QWL04mQJwQ2uM=`.
patching file BUILD.bazel
BcrValidationResult.FAILED: The patch file `modules/websocketpp/0.8.2.bcr.1/patches/module_dot_bazel.patch` has expected integrity value `sha256-Bq9+2iYvtN8TR5zGaKTIdS3vYsx/gEP0pM2xLWuMO2U=`, but the real integrity value is `sha256-h9esq/BSgla/GaK2cdr7QK71dXvYWj64udsLV06S180=`.

@meteorcloudy meteorcloudy merged commit b177f3e into bazelbuild:main Jul 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants