Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2372

Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Jul 7, 2024

Hello @aherrmann, modules you maintain (rules_zig) have been updated in this PR. Please review the changes.

aherrmann
aherrmann previously approved these changes Jul 7, 2024
bazel-io
bazel-io previously approved these changes Jul 7, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum enabled auto-merge (squash) July 7, 2024 17:00
@aherrmann
Copy link
Contributor

@fmeum I saw you enabled auto-merge, thanks!
But, I think CI is waiting on a BCR maintainer approval.

Bazel 8 is not released, yet.
auto-merge was automatically disabled July 8, 2024 16:10

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from aherrmann and themself July 8, 2024 16:11

Require module maintainers' approval for newly pushed changes.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 8, 2024
@meteorcloudy meteorcloudy enabled auto-merge (squash) July 9, 2024 11:10
@meteorcloudy meteorcloudy merged commit de916b5 into bazelbuild:main Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants