Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix foonathan_memory include path #2418

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

daohu527
Copy link
Contributor

@daohu527 daohu527 commented Jul 12, 2024

add "include/foonathan_memory" include path instead of "include"

In Fast-DDS which use below include path

#include <foonathan/memory/container.hpp>
#include <foonathan/memory/memory_pool.hpp>

If so, then we need to add out_include_dir = "include/foonathan_memory",, I don't know why bazel add foonathan_memory in external path?

  • source path include/foonathan/memory
  • bazel external path include/foonathan_memory/foonathan/memory

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (foonathan_memory) have been updated in this PR. Please review the changes.

@Wyverald
Copy link
Member

BCR has an append-only policy. Please submit your changes as a new version of foonathan_memory (in this case, 0.7.3.bcr.1).

@daohu527 daohu527 force-pushed the foonathan_memory branch 3 times, most recently from 25384d8 to af2716b Compare July 14, 2024 13:30
@daohu527
Copy link
Contributor Author

@Wyverald add a new version 0.7.3.bcr.1

@Wyverald Wyverald added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jul 14, 2024
add "include/foonathan_memory" include path instead of "include"
@Wyverald Wyverald merged commit 3e6de03 into bazelbuild:main Jul 15, 2024
16 checks passed
@daohu527 daohu527 deleted the foonathan_memory branch July 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants