Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new osqp-cpp version with osqp and suitesparse fixes #2419

Merged
merged 12 commits into from
Jul 15, 2024

Conversation

udaya2899
Copy link
Contributor

With the existing version of osqp-cpp, it uses long long. Although osqp works with long long, another dependency of osqp, SuiteSparse doesn't.

Therefore, although the code compiled, the program that depends on osqp-cpp fails while linking them. There are two errors primarily:

  1. Cannot find symbol amd_l_order used by qdldl_interface.c in osqp
    • Fix: define -DDLONG as cxxopt for building SuiteSparse. The current latest version 0.6.3.bcr.1 doesn't work and has been yanked.
  2. Cannot find symbol osqp_is_interrupted used by osqp++.c
    • Fix: Add src/ctrlc.c and include/ctrlc.h and define "CTRLC" while building. This is why a new version of osqp is needed with these ctrl-c interrupt definitions.

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (osqp, qdldl, suitesparse) have been updated in this PR. Please review the changes.

@Wyverald Wyverald added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jul 12, 2024
@Wyverald Wyverald merged commit 79f99a4 into bazelbuild:main Jul 15, 2024
30 checks passed
@udaya2899 udaya2899 deleted the udaya2899/debug-osqp-errors branch July 16, 2024 08:42
@Wyverald Wyverald mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants