Add "cppzmq" 4.10.0 and a header only target for "libzmq" 4.3.5.bcr.1. #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the operating system.
This change fixes the build on Mac OS X. According to the original CMakeLists.txt, "rt" is not linked on Mac OS X.
if (NOT APPLE)
set (WEBSOCKETPP_PLATFORM_LIBS pthread rt)
else()
set (WEBSOCKETPP_PLATFORM_LIBS pthread)
endif()
The reasons why cppzmq does not depend on the full target of libzmq are: 1. cppzmq is a header-only library, thus it should depend on headers only. Users of cppzmq should provide a libzmq independently, which may be another (locally patched) version. 2. The current libzmq on Bazel registry does not build on Mac M1 (ARM).
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cppzmq, libzmq) have been updated in this PR. Please review the changes. |
Wyverald
added
presubmit-auto-run
meteorcloudy
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons why cppzmq does not depend on the full target of libzmq are: