-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rules_perl w/ includes attr patch #2631
Conversation
Hello @mortenmj, modules you maintain (rules_perl) have been updated in this PR. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.
Please check the presubmit failures |
Require module maintainers' approval for newly pushed changes.
This is latest rules_perl plus
includes
attr to automate$PERL5LIB
bazel-contrib/rules_perl#62PATH_PREFIX=./
instead of failing to bazel run a program with a perl_binary data dep bazel-contrib/rules_perl#65Obviously it would be nice to get a review / merge this upstream. If that still happens we can add a new (0.2.4 ?) release without patches in the BCR.
The patch enables external rules_perl Bazel repos to work under Bzlmod. This is needed for https://github.com/lalten/rules_cpan to work out of the box
needs the
unstable source url
label