Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new module xacro #3731

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Add new module xacro #3731

merged 7 commits into from
Feb 19, 2025

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 5, 2025 •
edited
Loading

Adds a module for https://github.com/ros/xacro, a tool to expand xacro files (xml macros).

Upstream accepted patches for bzlmod support as well as rules for expanding these macro files at build-time with bazel.

@mjcarroll
Add new module xacro
f49318c 
Signed-off-by: Michael Carroll <[email protected]>
@bazel-io
Copy link
Member

bazel-io commented Feb 5, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (xacro) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@mjcarroll
Copy link
Contributor Author

mjcarroll commented Feb 5, 2025 •
edited by Wyverald
Loading

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Feb 5, 2025
@mjcarroll mjcarroll mentioned this pull request Feb 13, 2025
Merged
@mjcarroll
Update reference commit.
3973b91 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll marked this pull request as ready for review February 19, 2025 16:07
udaya2899
udaya2899 suggested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@udaya2899 udaya2899 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MODULE.bazel file and the patch looks not right

Edit: resolved

modules/xacro/2.0.12/presubmit.yml Outdated Show resolved Hide resolved
modules/xacro/2.0.12/presubmit.yml Show resolved Hide resolved
modules/xacro/2.0.12/patches/module_dot_bazel.patch Show resolved Hide resolved
modules/xacro/2.0.12/MODULE.bazel Show resolved Hide resolved
@mjcarroll
Drop unsupported platforms
8610c46 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Correct MODULE and patch
a8d377f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Update integrity
8e55766 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix patch
dd76406 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Fix patch and strip_prefix
8516e3b 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from udaya2899 February 19, 2025 19:42
udaya2899
udaya2899 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@udaya2899 udaya2899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 19, 2025
@fmeum fmeum enabled auto-merge (squash) February 19, 2025 21:46
@fmeum fmeum merged commit d853c49 into bazelbuild:main Feb 19, 2025
14 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/xacro branch February 19, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

@udaya2899 udaya2899 udaya2899 approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjcarroll @bazel-io @fmeum @udaya2899