Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for building curl with openssl. #3806

Merged
merged 13 commits into from
Feb 18, 2025
Merged

Added support for building curl with openssl. #3806

merged 13 commits into from
Feb 18, 2025

Conversation

vtsao-openai
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

Hello @keith, modules you maintain (curl) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@vtsao-openai vtsao-openai mentioned this pull request Feb 15, 2025
Merged
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 15, 2025
@vtsao-openai vtsao-openai requested a review from fmeum February 15, 2025 20:37
fmeum
fmeum approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keith

@vtsao-openai
Copy link
Contributor Author

Hey @keith could you PTAL, would love to get this in as it's blocking #3808. Thanks!

@vtsao-openai
Copy link
Contributor Author

@fmeum any chance we can get this merged without @keith's LGTM? It's been a few days now.

@vtsao-openai vtsao-openai requested a review from fmeum February 18, 2025 18:39
@keith
Copy link
Member

keith commented Feb 18, 2025

it was the weekend 🤔

@keith keith merged commit 73aca47 into bazelbuild:main Feb 18, 2025
31 checks passed
@keith
Copy link
Member

keith commented Feb 18, 2025

thanks!

@vtsao-openai vtsao-openai deleted the dev/vtsao/curl/openssl branch February 18, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum Awaiting requested review from fmeum

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtsao-openai @bazel-io @keith @fmeum