Show stack traces in the remote repo contents cache with --verbose_failures
#27970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailures` Makes it easier to debug issues with this experimental feature and also matches the behavior of remote execution/caching.
github-actions
bot
added
team-ExternalDeps
Collaborator
Author
|
FYI @keith |
Collaborator
Author
|
@bazel-io fork 9.0.0 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve debugging for the remote repository contents cache by showing stack traces with --verbose_failures. The implementation correctly propagates the verboseFailures flag. However, there is a logical error in maybeGetStackTrace which causes it to show the stack trace when --verbose_failures is off and only the message when it's on, which is the opposite of the intended behavior. I've provided a comment with a fix for this.
src/main/java/com/google/devtools/build/lib/remote/RemoteRepoContentsCacheImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Wyverald
reviewed
Dec 15, 2025
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryFetchFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Jan 3, 2026
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 7, 2026
…ailures` Makes it easier to debug issues with this experimental feature and also matches the behavior of remote execution/caching. Work towards bazelbuild#27965 Closes bazelbuild#27970. PiperOrigin-RevId: 853238791 Change-Id: Id46ccbb105d93fd17114fab13b086d0b46139fb4
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
…erbose_failures` (#28179) Makes it easier to debug issues with this experimental feature and also matches the behavior of remote execution/caching. Work towards #27965 Closes #27970. PiperOrigin-RevId: 853238791 Change-Id: Id46ccbb105d93fd17114fab13b086d0b46139fb4 Commit fc5f160 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to debug issues with this experimental feature and also matches the behavior of remote execution/caching.
Work towards #27965