Skip to content

Conversation

@meisterT
Copy link
Member

@meisterT meisterT commented Jan 7, 2026

We recommend using https://github.com/bazelbuild/bazelisk?#--bisect nowadays.

This is also closes #28172 which comes up with an example how this script could harm users on a multi-user machine.

Note that the script has never been shipped with Bazel, it just exists in the source tree of Bazel.

We recommend using https://github.com/bazelbuild/bazelisk?#--bisect
nowadays.

This is also closes bazelbuild#28172 which comes up with an example how this
script could harm users on a multi-user machine.

Note that the script has never been shipped with Bazel, it just exists
in the source tree of Bazel.
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 7, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the scripts/bazel-bisect.sh script. As the description correctly points out, this script is obsolete and has been replaced by the --bisect feature in Bazelisk. The removal also addresses a security concern related to its use of temporary files on multi-user systems. This is a good cleanup, and the change is approved.

@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 7, 2026
@copybara-service copybara-service bot closed this in 4d6ef1c Jan 7, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arbitrary File Overwrite via Symlink Attack in bazel-bisect.sh

2 participants