-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Implement SSL Certificate Monitor workflow #28176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f140e39 to
0b6b31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new, well-structured Python script and configuration file for monitoring SSL certificate expiration, which is a great improvement for infrastructure reliability. My review identifies a couple of areas in the new script where robustness and maintainability can be enhanced. Specifically, I've suggested replacing a broad exception with more specific ones to avoid masking potential bugs, and removing a redundant and misleading code block to improve clarity. These changes will make the script more robust and easier for future developers to maintain.
|
I have addressed both PR review suggestions:
|
89092a8 to
a51b35f
Compare
This PR introduces a new SSL certificate monitoring workflow for Bazel domains.
Core Changes:
.github/config/ssl_domains.yaml.