[8.5.1] Implement RepoMappingManifestAction#describeKey
#28181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Configurability
iancha1992
approved these changes
Jan 7, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the describeKey method for RepoMappingManifestAction, which will improve debuggability of action cache issues. The implementation correctly mirrors the logic in computeKey, providing a human-readable description of the components of the action key. The change also includes a refactoring of several MapFn fields to the more specific CommandLineItem.ExceptionlessMapFn, which is necessary for using the new describeNestedSetFingerprint helper and improves type safety. The changes are correct and well-implemented.
github-actions
bot
removed
the
awaiting-review
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jan 8, 2026
…#28181) Work towards bazelbuild#28056 Closes bazelbuild#28061. PiperOrigin-RevId: 852463750 Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584 Co-authored-by: Fabian Meumertzheim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
…28194) Work towards #28056 Closes #28061. PiperOrigin-RevId: 852463750 Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584 Commit c9cbff2 Co-authored-by: Xùdōng Yáng <[email protected]> Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #28056
Closes #28061.
PiperOrigin-RevId: 852463750
Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584