[9.0.0] Fix repo contents cache FileValue staleness
#28191
Conversation
Ensures that files under repo contents cache entries are not reported as missing after the cache has been deleted while the Bazel server is running. See the long comment in `RepositoryFetchFunction` for why this happens and how it is fixed. Fixes #26450 Closes #28147. PiperOrigin-RevId: 853622194 Change-Id: Ifba953b72258030e0a640ac49947ac5c5fc7620a
github-actions
bot
added
team-ExternalDeps
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a crucial fix for FileValue staleness in the repo contents cache, particularly when the cache is deleted while the Bazel server is running. The changes involve transitioning from FileValue to FileStateValue for cache entries and introducing a new REPO_CONTENTS_CACHE_DIRS file type to correctly handle the lifecycle of these directories within Skyframe. The propagation of the repoContentsCachePathSupplier across various components is well-implemented, ensuring the new logic is consistently applied. The detailed comments in RepositoryFetchFunction and ExternalFilesHelper provide excellent context and justification for the technical decisions made. New Python tests have been added to specifically validate the cache deletion scenario, which is a strong point of this PR. However, there is a TODO in one of the Python tests indicating an unintended behavior related to a Skyframe cycle, which needs to be addressed.
github-actions
bot
removed
the
awaiting-review
Ensures that files under repo contents cache entries are not reported as missing after the cache has been deleted while the Bazel server is running. See the long comment in
RepositoryFetchFunctionfor why this happens and how it is fixed.Fixes #26450
Closes #28147.
PiperOrigin-RevId: 853622194
Change-Id: Ifba953b72258030e0a640ac49947ac5c5fc7620a