[8.6.0] Implement RepoMappingManifestAction#describeKey (#28181)
#28194
+31
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#28181) Work towards bazelbuild#28056 Closes bazelbuild#28061. PiperOrigin-RevId: 852463750 Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584 Co-authored-by: Fabian Meumertzheim <[email protected]>
iancha1992
added
team-Configurability
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements describeKey for RepoMappingManifestAction to improve action key debugging. The implementation correctly mirrors the fields used in computeKey. Additionally, the code is refactored to use CommandLineItem.ExceptionlessMapFn instead of the more generic MapFn, which improves type safety. The changes are correct and improve both debuggability and code quality.
Wyverald
approved these changes
Jan 8, 2026
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #28056
Closes #28061.
PiperOrigin-RevId: 852463750
Change-Id: I100a76adf564aa11dbef1a98f48a6b1389c1d584
Commit c9cbff2