Make overlaid files executable in http_archive
#28202
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
@bazel-io fork 8.6.0 |
fmeum
added
the
soft-release-blocker
Collaborator
Author
|
@bazel-io fork 9.0.0 |
This was referenced Jan 9, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to make overlaid files in http_archive executable to support adding shell scripts. While this is a valid use case, the current implementation makes all overlaid files executable, which is a security concern as it violates the principle of least privilege. My review includes a critical comment suggesting a more secure approach by introducing a new attribute to explicitly specify which files should be executable.
This makes it possible to use registry overlays to add shell scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use registry overlays to add shell scripts.
Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969