Fix cycles when checking the local repo contents cache #28206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
local-repo-cache-fix
branch
from
71336e0 to
7c17c93
Compare
fmeum
commented
Jan 9, 2026
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryFetchFunction.java
Outdated
Show resolved
Hide resolved
…epositoryFetchFunction.java
Wyverald
reviewed
Jan 9, 2026
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
team-ExternalDeps
Collaborator
Author
|
@bazel-io fork 9.0.0 |
Wyverald
reviewed
Jan 10, 2026
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryFetchFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Jan 11, 2026
Collaborator
Author
|
@meteorcloudy I noticed that module extensions are affected as well after @Wyverald's review and import and pushed the analogous test and fix. Feel free to ignore and work with the imported CL if those changes come too late. |
Wyverald
reviewed
Jan 12, 2026
src/main/java/com/google/devtools/build/lib/bazel/repository/DigestWriter.java
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 12, 2026
Fixes bazelbuild#27517 by checking Skyframe deps in batches that stop right before any dep that may cause a cycle if checked while previous deps are out-of-date. This is accompanied by a restructuring of `RepoRecordedInput` that consolidates all Skyframe logic associated with the computation of the corresponding value exclusively within that class. This will also be helpful in adding support for dynamic inputs to the remote repo contents cache in future work. Also made the entirety of `RepositoryFetchFunction` use skyframe workers, so that checking the up-to-dateness of local repo contents cache entries isn't quadratic. Closes bazelbuild#28206. Co-authored-by: Xudong Yang <[email protected]> PiperOrigin-RevId: 855252657 Change-Id: Ica18760ae79da5155fc0f3d8cd4f24c52a034c86
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
Fixes #27517 by checking Skyframe deps in batches that stop right before any dep that may cause a cycle if checked while previous deps are out-of-date. This is accompanied by a restructuring of `RepoRecordedInput` that consolidates all Skyframe logic associated with the computation of the corresponding value exclusively within that class. This will also be helpful in adding support for dynamic inputs to the remote repo contents cache in future work. Also made the entirety of `RepositoryFetchFunction` use skyframe workers, so that checking the up-to-dateness of local repo contents cache entries isn't quadratic. Closes #28206. Co-authored-by: Xudong Yang <[email protected]> PiperOrigin-RevId: 855252657 Change-Id: Ica18760ae79da5155fc0f3d8cd4f24c52a034c86 Commit 72a25a9 Co-authored-by: Fabian Meumertzheim <[email protected]> Co-authored-by: Xudong Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27517 by checking Skyframe deps in batches that stop right before any dep that may cause a cycle if checked while previous deps are out-of-date. The same batching is applied to module extensions, which suffer from the same issue as demonstrated with a new test.
This is accompanied by a restructuring of
RepoRecordedInputthat consolidates all Skyframe logic associated with the computation of the corresponding value exclusively within that class. This will also be helpful in adding support for dynamic inputs to the remote repo contents cache in future work.Also made the entirety of
RepositoryFetchFunctionuse skyframe workers, so that checking the up-to-dateness of local repo contents cache entries isn't quadratic.