[8.6.0] Add bazel mod show_repo --output=streamed_proto and --output=streamed_jsonproto
#28207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut=streamed_jsonproto` Serialize repo definitions to the same `Target` proto that `bazel query` uses. A few more notable details: * Add back `_original_name`, even to the Starlark output. This was removed in bazelbuild#26493, but I believe it's still useful for debugging. * The output protos may contain a `$apparent_repo_name` or `$module_key` pseudo-attribute, which is the equivalent of the `## @repo_name` / `## module@version` line in the Starlark output. * Similar to the original Starlark output, the same (canonical) repo can be shown multiple times if the user explicitly specified the same repo in different ways: ```sh ❯ bazel-bin/src/bazel_nojdk mod show_repo @@rules_cc+ @rules_cc rules_cc ``` ```starlark ## @@rules_cc+: http_archive( name = "rules_cc+", ... ## @rules_cc: http_archive( name = "rules_cc+", ... ## [email protected]: http_archive( name = "rules_cc+", ... ``` ```sh ❯ bazel-bin/src/bazel_nojdk mod show_repo --output=streamed_jsonproto @@rules_cc+ @rules_cc rules_cc ``` ```js {"canonicalName":"rules_cc+", … {"canonicalName":"rules_cc+","apparentName":"@rules_cc", … {"canonicalName":"rules_cc+","moduleKey":"[email protected]", … ``` * Tighten up command argument validation so that `bazel mod show_{repo,extension} --output={graph,json}` now exits with an error, addressing a common source of user confusion. I decided not to add the same validation to all `bazel mod` subcommands since no one can possibly expect `bazel mod tidy --output=graph` to do something. Fixes bazelbuild#21617. Works towards bazelbuild#24692. Closes bazelbuild#27242.
This reverts commit 69970f1.
github-actions
bot
added
team-Performance
iancha1992
requested review from
Wyverald,
fweikert,
gregestren and
meteorcloudy
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new protobuf-based output formats for bazel mod show_repo and enhances argument validation for several mod subcommands. The changes are well-implemented, with corresponding updates to documentation and tests. My review focuses on improving the robustness of I/O operations. I've pointed out a couple of instances where IOExceptions are silently ignored, which could result in incomplete output without notifying the user. I've suggested handling these exceptions to ensure more reliable behavior.
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/modcommand/RepoOutputFormatter.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/modcommand/ModExecutor.java
Show resolved
Hide resolved
timothyg-stripe
commented
Jan 9, 2026
| aspectResolver.computeAspectDependencies(target, dependencyFilter); | ||
| ImmutableMap.of(); | ||
| if (aspectResolver != null) { | ||
| aspectsDependencies = aspectResolver.computeAspectDependencies(target, dependencyFilter); |
Contributor
Author
There was a problem hiding this comment.
There's already a null check for aspectResolver elsewhere in the file, so I thought this is warranted:
Wyverald
approved these changes
Jan 9, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements #27242 in terms of
BzlmodRepoRuleValuefor Bazel 8.x, as 8.x doesn't include #26493.Serialize repo definitions to a new
Repositoryproto message.A few more notable details:
Similar to the original Starlark output, the same (canonical) repo can be shown multiple times if the user explicitly specified the same repo in different ways:
Tighten up command argument validation so that
bazel mod show_{repo,extension} --output={graph,json}now exits with an error, addressing a common source of user confusion. I decided not to add the same validation to allbazel modsubcommands since no one can possibly expectbazel mod tidy --output=graphto do something.Fixes #21617.
Works towards #24692.
Closes #27242.
Fixes #28009.