Reland "Avoid repo mapping lookup to check builtin restrictions" #28217
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7111cbf, with an additional fallback to a repo mapping lookup for the main repo to accomodate the tests in rules_cc and rules_java.
github-actions
bot
added
the
awaiting-review
There was a problem hiding this comment.
Pull request overview
This PR relands a previously reverted performance optimization that avoids expensive repository mapping lookups when checking builtin API access restrictions. The original regression has been fixed by adding a fallback to repo mapping lookup specifically for the main repository case to accommodate tests in rules_cc and rules_java.
Changes:
- Introduced
reposMatch()helper method that optimizes repository name matching by avoidingRepositoryMapping.get()calls in most cases - Replaced string-based comparison with constant-based comparison for the
_builtinsrepository check - Added import for
RepositoryNameclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/google/devtools/build/lib/packages/BuiltinRestriction.java
Show resolved
Hide resolved
Collaborator
Author
|
@bazel-io fork 9.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7111cbf, which in turn reverted cecc26b.
The regression is fixed by adding an additional fallback to a repo mapping lookup for the main repo to accommodate the tests in rules_cc and rules_java. The restructuring of the checks also results in a further improvement down to a 1% slowdown incurred by the checks (vs. 10-20% before this change).