[9.0.0] Reland "Avoid repo mapping lookup to check builtin restrictions" #28254
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7111cbf, which in turn reverted cecc26b. The regression is fixed by adding an additional fallback to a repo mapping lookup for the main repo to accommodate the tests in rules_cc and rules_java. The restructuring of the checks also results in a further improvement down to a 1% slowdown incurred by the checks (vs. 10-20% before this change). Closes bazelbuild#28217. PiperOrigin-RevId: 855249997 Change-Id: I7da63fa9d6727a771e94be86bf62e7a6f957cfc7
bazel-io
added
the
awaiting-review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request relands a performance optimization for checking builtin restrictions, which was previously reverted due to a regression. The change avoids expensive repository mapping lookups by adding fast paths for Bzlmod-managed repositories and the bazel_tools repository. The regression is addressed by reintroducing a repository mapping lookup as a fallback, but only when checking labels in the main repository. This ensures correctness for allowlisted rulesets that might be the main repository. The logic appears sound and the refactoring to use RepositoryName.BUILTINS is a good improvement.
Wyverald
approved these changes
Jan 12, 2026
Merged
via the queue into
bazelbuild:release-9.0.0
with commit Jan 12, 2026
26760a0
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7111cbf, which in turn reverted cecc26b.
The regression is fixed by adding an additional fallback to a repo mapping lookup for the main repo to accommodate the tests in rules_cc and rules_java. The restructuring of the checks also results in a further improvement down to a 1% slowdown incurred by the checks (vs. 10-20% before this change).
Closes #28217.
PiperOrigin-RevId: 855249997
Change-Id: I7da63fa9d6727a771e94be86bf62e7a6f957cfc7
Commit 37fb3c5