[9.0.0] Make overlaid files executable in http_archive
#28276
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use registry overlays to add shell scripts. Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969 Closes bazelbuild#28202. PiperOrigin-RevId: 855699722 Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09
bazel-io
added
the
awaiting-review
meteorcloudy
approved these changes
Jan 13, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully implements the functionality to make overlaid files executable in http_archive, which is crucial for supporting shell scripts in registry overlays. The changes to MODULE.bazel.lock are expected updates due to underlying .bzl file modifications. The core change in tools/build_defs/repo/utils.bzl directly addresses the stated goal of the pull request by setting the executable flag to True for downloaded remote files, enabling proper execution of shell scripts. No critical or high severity issues were found in the provided changes.
Merged
via the queue into
bazelbuild:release-9.0.0
with commit Jan 13, 2026
1fbddaf
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use registry overlays to add shell scripts.
Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1767975320777969
Closes #28202.
PiperOrigin-RevId: 855699722
Change-Id: I65891a0cb6d7e99d70ab33c8b38f1c7da943fc09
Commit 3efde5a