Skip to content

Replace legacy struct providers with modern ones #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: google
Choose a base branch
from
Open

Replace legacy struct providers with modern ones #7573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aspect/fast_build_info.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def _fast_build_info_impl(target, ctx):

output_groups = depset(output_files, transitive = dep_outputs)

return struct(output_groups = {"ide-fast-build": output_groups})
return OutputGroupInfo(**{"ide-fast-build": output_groups})

def _get_all_dep_outputs(dep_targets):
"""Get the ide-fast-build output files for all dependencies"""
Expand Down
4 changes: 2 additions & 2 deletions aspect/intellij_info_impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,10 +1058,10 @@ def intellij_info_aspect_impl(target, ctx, semantics):

tags = ctx.rule.attr.tags
if "no-ide" in tags:
return struct()
return []

if _is_analysis_test(target):
return struct()
return []

rule_attrs = ctx.rule.attr

Expand Down