CLion: include cache #7834
CLion: include cache #7834
Conversation
LeFrosch
force-pushed
the
include-cache
branch
4 times, most recently
from
4163454 to
fc050f2
Compare
LeFrosch
force-pushed
the
include-cache
branch
from
cf10f69 to
7f7a92e
Compare
github-actions
bot
added
product: CLion
LeFrosch
force-pushed
the
include-cache
branch
from
df09749 to
9618aa5
Compare
|
Windows failure caused by: Maybe separate rules foreign cc tests, seem to be more restrictive then the general virtual includes tests. |
| this.sources.addAll(cIdeInfo.ruleContext().headers()); | ||
| this.sources.addAll(cIdeInfo.ruleContext().textualHeaders()); | ||
|
|
||
| // TODO: add compilation context direct headers here too? (they can contain duplicates, filter?) |
There was a problem hiding this comment.
can we update this comment with the testonly usage and drop todo then?
|
|
||
| private const val MODULES_DIRECTORY = "modules" | ||
|
|
||
| abstract class AspectModuleWriter : AspectWriter { |
There was a problem hiding this comment.
let's add documentation here
| addAllowedVfsRoots(roots); | ||
|
|
||
| Assertions.assertVfsLoads(myBazelInfo.executionRoot(), roots); | ||
| HeavyPlatformTestCase.cleanupApplicationCaches(myProject); |
There was a problem hiding this comment.
let's leave a comment why do we want to have it here or maybe remove it if we don't need
|
|
||
| http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
let's consider switching from sqlite to our own simple library built with cmake, I guess we can store it right in this repo and drop BUILD.sqlite.bazel and directly use configure_cmake?
| .map(TargetKey::toString) | ||
| .collect(joining("\n")); | ||
|
|
||
| IssueOutput.warn(String.format("cc target depends on %d apple cc toolchains", entry.getKey())) |
There was a problem hiding this comment.
let's preserve the old message as it looks to be more descriptive
| fun resolve(target: TargetKey, artifact: ArtifactLocation): Path? { | ||
| if (!artifact.isGenerated) return null | ||
|
|
||
| val path = target.cacheDirectory().resolve(stripVirtualPrefix(artifact.relativePath)) |
| var size = 0L | ||
|
|
||
| try { | ||
| for (item in Files.walk(path)) { |
There was a problem hiding this comment.
|
|
||
| if (Files.exists(cacheDirectory)) { | ||
| // I have a feeling that this will be really slow on Windows, so let's try to avoid this | ||
| NioFiles.deleteRecursively(cacheDirectory) |
There was a problem hiding this comment.
let's leave a comment that we'd like to later replace it with rename and delete async
| if (importSettings != null) { | ||
| BlazeDataStorage.getProjectDataDir(importSettings).toPath().resolve(CC_INCLUDES_CACHE_DIR) | ||
| } else { | ||
| Path.of(project.basePath, CC_INCLUDES_CACHE_DIR) |
|
|
||
| private fun findVirtualIncludesDirectory(bazelBin: Path, label: Label): Path? { | ||
| val path = bazelBin | ||
| .applyIf(label.externalWorkspaceName() != null) { resolve("external").resolve(label.externalWorkspaceName()) } |
The PR adds a cache for generated headers and
_virtual_includedirectories of a target to avoid placing header search paths into the execution root.Header search paths in the execution root can cause unnecessary files to be loaded into the VFS, since indexing code might recursively iterate over all files in these directories.