Fix: ProguardMapping is not queryable nor deterministically generated #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Jan 17, 2024
| @@ -52,6 +53,8 @@ def make_rule( | |||
| "@bazel_tools//tools/jdk:toolchain_type", | |||
| ] + additional_toolchains, | |||
| _skylark_testable = True, | |||
| outputs = { | |||
There was a problem hiding this comment.
Isn't this only a valid change if android_binary outputs proguard mappings for every single android_binary target, which wouldn't be true for local debug APKs that don't run proguard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #194
The way to fix this is to explicitly declare the proguard mapping file. This will mean that the file will trigger a rebuild.
This fix may be incomplete though since this artifact may need to be declared as the input to the release target itself. If the proguard file changes then the proguarded build should be rebuilt as well.
Looking for comment/revision.