-
Notifications
You must be signed in to change notification settings - Fork 72
Add current_proto_toolchain #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
psalaberria002
wants to merge
7
commits into
bazelbuild:main
Choose a base branch
from
psalaberria002:ps/make-var
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
11311d1
Add current_proto_toolchain
psalaberria002 d463d3c
Add and register toolchain
psalaberria002 aa868a3
sh_test
psalaberria002 cbecc91
buildifier
psalaberria002 8c701db
no windows
psalaberria002 170bb75
usr/bin/env
psalaberria002 ed1bb66
skip windows
psalaberria002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
load("//proto:defs.bzl", "current_proto_toolchain") | ||
|
||
current_proto_toolchain( | ||
name = "current_proto_toolchain", | ||
) | ||
|
||
genrule( | ||
name = "gen_protoc_help_from_current_proto_toolchain", | ||
srcs = [], | ||
outs = ["protoc_help_from_current_proto_toolchain"], | ||
cmd = """ | ||
v=$$($(PROTOC) --help) | ||
echo $$v > $(OUTS) | ||
""", | ||
target_compatible_with = select({ | ||
"@platforms//os:windows": ["@platforms//:incompatible"], | ||
"//conditions:default": [], | ||
}), | ||
toolchains = [":current_proto_toolchain"], | ||
) | ||
|
||
# The genrule above will fail if PROTOC cannot be found, but using genrules for tests isn't recommended. | ||
# This sh_test just checks if the output of the genrule has any content. | ||
sh_test( | ||
name = "test_protoc_help_from_current_proto_toolchain", | ||
srcs = ["test_protoc_help_from_current_proto_toolchain.sh"], | ||
data = [":protoc_help_from_current_proto_toolchain"], | ||
env = { | ||
"PROTOC_HELP_OUTPUT": "$(location :protoc_help_from_current_proto_toolchain)", | ||
}, | ||
target_compatible_with = select({ | ||
"@platforms//os:windows": ["@platforms//:incompatible"], | ||
"//conditions:default": [], | ||
}), | ||
) |
4 changes: 4 additions & 0 deletions
4
tests/current_toolchain/test_protoc_help_from_current_proto_toolchain.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env sh | ||
|
||
# Fail if the file in the PROTOC_HELP_OUTPUT environment variable is empty | ||
[ -s "$PROTOC_HELP_OUTPUT" ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.