Skip to content

Commit

Permalink
fix: remove bzlmod pip.parse() annotations attribute (#1808)
Browse files Browse the repository at this point in the history
This change removes unused attributes from the `bzlmod` APIs cleaning up
the docs and src code.

---------

Co-authored-by: Ignas Anikevicius <[email protected]>
  • Loading branch information
jbedard and aignas authored May 19, 2024
1 parent daf4224 commit 1036a4d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ A brief description of the categories of changes:
also now handled correctly, stabilizing the implementation.
* (gazelle) Fix Gazelle failing on Windows with
"panic: runtime error: invalid memory address or nil pointer dereference"
* (bzlmod) remove `pip.parse(annotations)` attribute as it is unused and has been
replaced by whl_modifications.

### Added
* (rules) Precompiling Python source at build time is available. but is
Expand Down
3 changes: 3 additions & 0 deletions python/private/bzlmod/pip.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,9 @@ The labels are JSON config files describing the modifications.
# don't allow users to override it.
attrs.pop("repo_prefix")

# annotations has been replaced with whl_modifications in bzlmod
attrs.pop("annotations")

return attrs

def _whl_mod_attrs():
Expand Down

0 comments on commit 1036a4d

Please sign in to comment.