Skip to content

Commit

Permalink
fix changlog, add note about com_google_protobuf repo name
Browse files Browse the repository at this point in the history
  • Loading branch information
rickeylev committed Nov 21, 2024
1 parent ffb3798 commit 7771c0d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ Unreleased changes template.
bzlmod extension.
* (bzlmod) `pip.parse.parse_all_requirements_files` attribute has been removed.
See notes in the previous versions about what to do.
* (deps) rules_cc 0.0.16
* (deps) protobuf 29.0-rc2 (workspace; bzlmod already specifying that version)
* (deps) rules_cc 0.1.0 (workspace) and 0.0.16 (bzlmod).
* (deps) protobuf 29.0-rc2 (workspace; bzlmod already specifying that version).

Other changes:
* (python_repository) Start honoring the `strip_prefix` field for `zstd` archives.
Expand All @@ -91,7 +91,7 @@ Other changes:
* (binaries/tests) ({obj}`--bootstrap_impl=scipt`) Using `sys.executable` will
use the same `sys.path` setup as the calling binary.
([2169](https://github.com/bazelbuild/rules_python/issues/2169)).
* (workspace): Corrected protobuf's name to com_google_protobuf, the name is
* (workspace) Corrected protobuf's name to com_google_protobuf, the name is
hardcoded in Bazel, WORKSPACE mode.

{#v0-0-0-added}
Expand Down
4 changes: 3 additions & 1 deletion python/private/py_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ def py_repositories():
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.0/rules_cc-0.1.0.tar.gz"],
)

# Needed by rules_cc, triggerred by @rules_java_prebuilt in Bazel by using @rules_cc//cc:defs.bzl
# Needed by rules_cc, triggered by @rules_java_prebuilt in Bazel by using @rules_cc//cc:defs.bzl
# NOTE: This name must be com_google_protobuf until Bazel drops WORKSPACE
# support; Bazel itself has references to com_google_protobuf.
http_archive(
name = "com_google_protobuf",
sha256 = "23082dca1ca73a1e9c6cbe40097b41e81f71f3b4d6201e36c134acc30a1b3660",
Expand Down

0 comments on commit 7771c0d

Please sign in to comment.