Skip to content

Commit

Permalink
examples(pip_parse): fix circular deps with sphinx by breaking cycles (
Browse files Browse the repository at this point in the history
…#1596)

When the pip_parse example was updated to use sphinx to demonstrate
circular deps, its MODULE.bazel config was forgotten to also be updated
to use the requirement_cycles feature to break the circular deps.

Fixes #1595
  • Loading branch information
rickeylev authored Dec 6, 2023
1 parent a1169f1 commit ee2cc93
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions examples/pip_parse/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ python.toolchain(

pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
pip.parse(
experimental_requirement_cycles = {
"sphinx": [
"sphinx",
"sphinxcontrib-serializinghtml",
"sphinxcontrib-qthelp",
"sphinxcontrib-htmlhelp",
"sphinxcontrib-devhelp",
"sphinxcontrib-applehelp",
],
},
hub_name = "pypi",
python_version = "3.9",
requirements_lock = "//:requirements_lock.txt",
Expand Down

0 comments on commit ee2cc93

Please sign in to comment.