-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runfiles): Add static methods to Runfiles
class to simplify interface
#1656
Conversation
cc @aignas is this one ok as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look at it later early next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't like the Create method, because it smells of bad polymorphism design, but at the same time i think that allowing easy type annotations is a not win. @rickeylev, what do you think?
If there's no blockers is this something that could be merged soon? I think it'd be good to consolidate the import paths for pypi releases and rules_python releases but that should be a separate change. |
@UebelAndre, just came back from holiday. Sorry for being pedantic, but as per the PR template todo checklist, could you please add a |
What do you mean "more like a commit message"? If you modify the description to your liking I can make sure my future PRs follow this pattern. |
Condensed the message slightly and used passive voice and reworded to sound more like what is being added/changed with the commit rather than what is proposed. Thanks a lot for the improvements to |
With this change we allow for more ergonomic creation of the runfiles
object and using type annotations:
Furthermore, the docs have been updated to describe pulling
runfiles
library directly from
rules_python
to avoid the complexity of needingto setup
pip_parse
to use this behavior.