Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rules_python bzlmod GA and 1.0 prep #2296
docs: rules_python bzlmod GA and 1.0 prep #2296
Changes from all commits
6fea69a
746492f
29858d8
665e434
7a445fa
b082b76
188c476
d16bb57
a517ca8
e9f01d6
bff95ed
60b81c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Are you sure about this change? I'm +1 on increasing to a newer version. Doesn't the extracted variables make it easier to bump versions in future? Or are you thinking there aren't major benefits to the indirection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking that one needs to copy the sha and version separately instead of just replacing the whole block of
http_archive
. If we had the indirection in thereleases
page, then sure, I think we should keep it, but thereleases
page does not have that.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. Yes. If we could prepare a full copy-paste snippet somewhere that is kept up to date automatically, that would be cool. Im fine with your change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the snippet is in the
releases
page, e.g. https://github.com/bazelbuild/rules_python/releases/tag/0.36.0Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.