Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flip auto exec groups flag internally #2306

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 15, 2024

I went through all of the invocations of ctx.actions.run and
ctx.actions.run_shell and it seems that we are setting the toolchain args
correctly where toolchains are used in the execution of the command.

Fixes #2282.

@aignas aignas marked this pull request as draft October 15, 2024 14:10
@aignas
Copy link
Collaborator Author

aignas commented Oct 15, 2024

Changing to draft until bazel ecosystem is more ready.

@rickeylev
Copy link
Collaborator

From CI:

(13:51:09) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/protobuf~/python/BUILD.bazel:53:20: in internal_copy_files_impl rule @@protobuf~//python:copied_wkt_proto_files:
Traceback (most recent call last):
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/protobuf~/python/internal.bzl", line 57, column 24, in _internal_copy_files_impl
		ctx.actions.run(
Error in run: Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'.

It looks like that error is coming from protobuf. Maybe we're missing an arg being passed to them? Or maybe we'll have to wait for them to fix.

@rickeylev rickeylev added the need: upstream support An issue that needs changes in upstream code label Oct 21, 2024
@aignas
Copy link
Collaborator Author

aignas commented Nov 19, 2024

Seems that we need to wait for a release that includes the change in protocolbuffers/protobuf@80a5a51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need: upstream support An issue that needs changes in upstream code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration needed for Automatic Exec Groups
2 participants