fix: upgrade to bazel_features 1.21.0 for Bazel 8 rc3 support #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure looks to be because of bazelbuild/stardoc#261 It only affects building our docs (or more precisely, building the stardoc protos), so I'll force-merge past it. |
aignas
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel_features has a bug where it doesn't detect Bazel 8 rc3 correctly. This is
fixed in release 1.21.0.
From the discussion on bazel-contrib/bazel_features#82,
it's likely this only occurs due to the "rc" notation of the Bazel release, so an
earlier bazel_features version will probably work fine once Bazel 8 is no longer rc.